Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and warnings #174

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Tests and warnings #174

merged 2 commits into from
Jul 28, 2023

Conversation

AaronRobinsonMSFT
Copy link
Owner

@AaronRobinsonMSFT AaronRobinsonMSFT commented Jul 28, 2023 •
edited
Loading

Address warnings on arm.

Convert to using __atomic_compare_exchange_n from __sync_val_compare_and_swap.

Update instance test to not print to console and instead return so validation is possible.

Supersedes #173

/cc @jtschuster @jkoritzinsky

@AaronRobinsonMSFT
Address warnings on arm.
d47bb06 
Convert to using __atomic_compare_exchange_n from
   __sync_val_compare_and_swap.
@AaronRobinsonMSFT
Update instance test to not print to console and
d6175c0 
instead return so validation is possible.
@AaronRobinsonMSFT
Copy link
Owner Author

/cc @elinor-fung

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit c57ad8b into master Jul 28, 2023
6 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the tests_and_warnings branch July 28, 2023 22:05
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronRobinsonMSFT @jkoritzinsky @elinor-fung